fix: tighten file perms and enforce Slack ACL checks#186
Merged
lxowalle merged 1 commit intosipeed:mainfrom Feb 16, 2026
Merged
fix: tighten file perms and enforce Slack ACL checks#186lxowalle merged 1 commit intosipeed:mainfrom
lxowalle merged 1 commit intosipeed:mainfrom
Conversation
- write config and cron store with 0600 instead of 0644 - check allow list in Slack slash commands and app mentions - pass workspace restrict flag to cron exec tool Closes sipeed#179
Collaborator
|
Thanks for the pr |
boengai
added a commit
to boengai/picoclaw
that referenced
this pull request
Feb 16, 2026
Keep both TestProviderConfig_EnvVars (from sipeed#66) and TestSaveConfig_FilePermissions (from sipeed#186). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
edgargomero
pushed a commit
to edgargomero/kntorclaw
that referenced
this pull request
Feb 16, 2026
- write config and cron store with 0600 instead of 0644 - check allow list in Slack slash commands and app mentions - pass workspace restrict flag to cron exec tool Closes sipeed#179
emadomedher
pushed a commit
to emadomedher/picoclaw
that referenced
this pull request
Feb 17, 2026
- write config and cron store with 0600 instead of 0644 - check allow list in Slack slash commands and app mentions - pass workspace restrict flag to cron exec tool Closes sipeed#179
Contributor
|
@is-Xiaoen Tightening file permissions to 0600 and adding the Slack ACL checks is important security hygiene, especially since those files can hold API keys and tokens. Solid work! We're building the PicoClaw Dev Group on Discord for contributors. Want to join? Just send an email to |
Contributor
Author
|
Thanks! Happy to contribute. I'll send the email to join the Discord dev group. |
3 tasks
ra1phdd
pushed a commit
to ra1phdd/picoclaw-pkg
that referenced
this pull request
Apr 12, 2026
- write config and cron store with 0600 instead of 0644 - check allow list in Slack slash commands and app mentions - pass workspace restrict flag to cron exec tool Closes sipeed#179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the three items in #179:
0600instead of0644, consistent withauth/store.go. Both files may contain API keys / bot tokens.handleAppMentionandhandleSlashCommandnow checkIsAllowed()early, before adding reactions or forwarding messages.NewCronToolwas hardcodingrestrict=false; now passes the config'sRestrictToWorkspacevalue through.Test plan
go vet ./...cleango test ./...passes (pre-existingpkg/authWindows-only failures unrelated)t.Skipon Windows)gofmtcleanCloses #179