Merged
Conversation
sivchari
force-pushed
the
feat/s3-multipart-upload
branch
from
d9743aa to
41f5ffd
Compare
Implement S3 Multipart Upload APIs to support uploading large files in parts: - CreateMultipartUpload: initiate a multipart upload - UploadPart: upload a part (1-10000) - CompleteMultipartUpload: complete upload by assembling parts - AbortMultipartUpload: cancel an in-progress upload - ListMultipartUploads: list in-progress uploads in a bucket - ListParts: list uploaded parts for a multipart upload Changes: - Add multipart upload types and response structures - Implement in-memory storage for multipart uploads - Add route dispatchers to handle query parameter-based routing - Calculate multipart ETag as MD5 of concatenated part MD5s - Add 4 integration tests using AWS SDK v2 Closes #3
sivchari
force-pushed
the
feat/s3-multipart-upload
branch
from
41f5ffd to
c923cdb
Compare
Contributor
📊 Integration Test Coverage ReportTotal Coverage: 64.5% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement S3 Multipart Upload APIs to support uploading large files in parts.
Changes
APIs Implemented
Implementation Details
?uploads→ CreateMultipartUpload?uploadId=X&partNumber=Y→ UploadPart?uploadId=X(POST) → CompleteMultipartUpload?uploadId=X(DELETE) → AbortMultipartUpload?uploads(GET bucket) → ListMultipartUploads?uploadId=X(GET object) → ListPartsMD5-of-MD5s-NformatFiles Changed
internal/service/s3/types.go: +103 lines (multipart types)internal/service/s3/storage.go: +294 lines (storage implementation)internal/service/s3/handlers.go: +382 lines (handlers + dispatchers)internal/service/s3/service.go: +13 lines (route registration)test/integration/s3_test.go: +323 lines (4 tests)Testing
All integration tests pass:
Closes
Closes #3