feat(athena): add Athena service implementation#211
Merged
Conversation
Implement Athena service emulator with the following APIs: - StartQueryExecution - StopQueryExecution - GetQueryExecution - GetQueryResults - ListQueryExecutions - CreateWorkGroup - DeleteWorkGroup The implementation uses AWS JSON 1.1 protocol via X-Amz-Target header dispatching. Query executions are stored in memory and immediately return with SUCCEEDED state for testing purposes. Includes integration tests for all implemented APIs. Closes #34
- Rename AclConfiguration to ACLConfiguration per Go naming convention - Rename AclConfigurationOutput to ACLConfigurationOutput - Add tagliatelle exclusion for athena/types.go in golangci.yaml - Update handlers.go references to use new type names
- Fix revive naming issues: AthenaError -> QueryError, AthenaServiceError -> ServiceError - Fix var-naming: QueryExecutionId -> QueryExecutionID, QueryExecutionIds -> QueryExecutionIDs - Fix var-naming: UsedReservationId -> UsedReservationID - Fix gocritic paramTypeCombine in storage.go - Fix gosec G115 integer overflow by using int(maxResults) comparison - Fix staticcheck S1016 by using type conversion for Datum and ColumnInfo - Fix gocritic rangeValCopy by using index iteration - Fix funlen by extracting helper functions: - convertResultConfigToOutput, convertStatisticsToOutput, convertEngineVersionToOutput - createMockResultSet
- Fix revive var-naming in QueryExecutionOutput.QueryExecutionID - Fix revive var-naming in GetQueryResultsRequest.QueryExecutionID - Fix gocritic paramTypeCombine in StartQueryExecution signature - Update handlers.go references for renamed fields
Contributor
📊 Integration Test Coverage ReportTotal Coverage: 65.6% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/service/athena/with service, handlers, storage, and typescmd/awsim/main.gotest/integration/athena_test.goAPIs Implemented
Test Plan
Closes #34