feat(batch): add Batch service basic implementation#226
Merged
Conversation
sivchari
force-pushed
the
feat/batch-basic-implementation
branch
4 times, most recently
from
b181686 to
785acc3
Compare
Implement AWS Batch service with the following operations: - CreateComputeEnvironment - DeleteComputeEnvironment - DescribeComputeEnvironments - CreateJobQueue - DeleteJobQueue - DescribeJobQueues - RegisterJobDefinition - SubmitJob - DescribeJobs - TerminateJob Uses AWS JSON 1.1 protocol with X-Amz-Target header routing. Includes in-memory storage and integration tests using AWS SDK v2. Closes #38
- Add missing AWS SDK batch package dependency - Fix createBatchClient helper to use inline config loading - Remove dependency on non-existent loadAWSConfig and testEndpoint
sivchari
force-pushed
the
feat/batch-basic-implementation
branch
from
785acc3 to
510fa71
Compare
AWS SDK v2 Batch client uses REST JSON protocol with paths like /v1/createcomputeenvironment instead of X-Amz-Target header routing. - Remove JSONProtocolService interface methods (TargetPrefix, JSONProtocol) - Register REST JSON routes in RegisterRoutes - Remove DispatchAction and target constants from handlers - Add SDK-based unit tests Fixes integration test failures where XML was returned instead of JSON.
Fix test assertion comparing int32 value to *int32 pointer. The AWS SDK v2 RegisterJobDefinitionOutput.Revision field is *int32, so it needs to be dereferenced in the assertion.
Contributor
📊 Integration Test Coverage ReportTotal Coverage: 65.5% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement AWS Batch service with the following operations:
Uses AWS JSON 1.1 protocol with X-Amz-Target header routing.
Changes
internal/service/batch/with service implementationTest plan
make lintpassesmake testpassesCloses #38