Conversation
remove unneseccary and breaking check for the property that doesn't exist in FiberNode
zhzz
changed the title
wKich
approved these changes
Feb 5, 2020
lossir
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Подробности в #1866.
Выяснилось, что поля
_nodeв Fiber'е нет. Оно использовалось до 16.0.0, но уже мертвый код был выпилен только в 16.1.0.Кроме этого, отрефакторил компоненты для порядка и чтобы работало со старым react-selenium-testing.
PR #1480 про то же, но решение не работает.
fix #1866
close #1480