Merged
Conversation
srajiang
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2134 +/- ##
=======================================
Coverage 82.03% 82.03%
=======================================
Files 18 18
Lines 1536 1536
Branches 442 442
=======================================
Hits 1260 1260
Misses 178 178
Partials 98 98 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Jun 12, 2024
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
Awesome saucesome on such a quick fix! 🚀 Thanks for linking the docs too - LGTM!
This was referenced Sep 5, 2024
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2133
Corrects typing to align with documentation and actual API behavior.
Requirements (place an
xin each[ ])