Merged
Conversation
|
Thanks for the contribution! Before we can merge this, we need @lwasyl to sign the Salesforce Inc. Contributor License Agreement. |
ZacSweers
approved these changes
Dec 4, 2023
Contributor
|
You may need to update the AGP version to 8.2.0 too? |
Contributor
|
ahhh blerg it was the gradle wrapper validation. Restarted it re: CLA – yep sorry, our new salesforce overlord have their own CLA and didn't go update repos so I guess I'll do that at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with
./gradlew buildContributingdoc mention signing CLA: https://slackhq.github.io/keeper/contributing/#requirementsbut the link doesn't work: