Skip to content

[Bugfix] Broken Heartbeat system in Row Streamer (#18390) #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tanjinx merged 5 commits into from
Aug 6, 2025
Merged

[Bugfix] Broken Heartbeat system in Row Streamer (#18390) #682

tanjinx merged 5 commits into from
Aug 6, 2025

Conversation

@tanjinx
Copy link

@tanjinx tanjinx commented Aug 6, 2025 •
edited
Loading

Description

This PR backports v23 PR vitessio#18390 to slack-19.0
and the test fix vitessio#18414

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@github-actions github-actions bot added this to the v19.0.7 milestone Aug 6, 2025
@tanjinx tanjinx marked this pull request as ready for review August 6, 2025 18:45
@tanjinx tanjinx requested a review from a team as a code owner August 6, 2025 18:45
sbaker617
sbaker617 reviewed Aug 6, 2025
View reviewed changes
tanjinx added 3 commits August 6, 2025 13:00
@tanjinx
fix spaces
2e6e84c 
Signed-off-by: Tanjin Xu <[email protected]>
@tanjinx
undo golangci
561a580 
Signed-off-by: Tanjin Xu <[email protected]>
@tanjinx
undo golangci
8146c71 
Signed-off-by: Tanjin Xu <[email protected]>
sbaker617
sbaker617 approved these changes Aug 6, 2025
View reviewed changes
Copy link

@sbaker617 sbaker617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tanjinx tanjinx merged commit 7a5f16f into slack-19.0 Aug 6, 2025
163 of 166 checks passed
@tanjinx tanjinx deleted the tanjin-backport-upstream-18390 branch August 6, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbaker617 sbaker617 sbaker617 approved these changes

Assignees

No one assigned

Labels

cla:signed v23-backport

Projects

None yet

Milestone

v19.0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@tanjinx @sbaker617 @siddharth16396