Highscores customization#302
Draft
slawkens wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made it to allow for customization of the highscores page.
What you can do with this:
I will post an example I've made, maybe you have some better ideas how we can approach this?
Maybe there is simpler way for allowing customisations of the highscores page?
Maybe it could be done with just 1 hook?
I'm waiting for your ideas, how can we make this better!
Example with reborns:
plugin.json
plugins/reborn-test/hooks/highscores-list.php
plugins/reborn-test/hooks/highscores.php
Example with charms points & boss points (canary):
plugin.json
plugins/theme-canary/hooks/highscores-list.php
plugins/theme-canary/hooks/highscores.php