Skip to content

fix: mismatched types#360

Merged
slawlor merged 2 commits intoslawlor:mainfrom
leoregul:main
May 30, 2025
Merged

fix: mismatched types#360
slawlor merged 2 commits intoslawlor:mainfrom
leoregul:main

Conversation

@leoregul
Copy link
Contributor

Fix error[E0308]: mismatched types in case of tokio_unstable flag is enabled
Also, added missed line reply.send(handle)

@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (4f6d8e0) to head (33a6737).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ractor_cluster/src/node/client.rs 0.00% 4 Missing ⚠️
ractor/src/factory/job.rs 0.00% 3 Missing ⚠️
ractor_cluster/src/net/listener.rs 0.00% 1 Missing ⚠️
ractor_cluster/src/node.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   80.99%   80.99%   -0.01%     
==========================================
  Files          70       70              
  Lines       14415    14419       +4     
==========================================
+ Hits        11675    11678       +3     
- Misses       2740     2741       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slawlor
Copy link
Owner

slawlor commented May 29, 2025

Can you address the clippy line and update the pr? Thanks

Copy link
Owner

@slawlor slawlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@slawlor slawlor merged commit 38faea5 into slawlor:main May 30, 2025
19 of 21 checks passed
@leoregul
Copy link
Contributor Author

Thanks for the fix!

Not at all, thank you for the great project!

Officeyutong pushed a commit to Officeyutong/ractor that referenced this pull request Jun 10, 2025
update async_trait macro

update

update

update

make fmt happy

fix: mismatched types (slawlor#360)

* fix: mismatched types

* fix: lint issues

---------

Co-authored-by: Igor Durapov <igor.durapov@megogo.net>

update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants