parley: Implement caching of parley layouts#10830
Draft
Conversation
The result of shaping is cached in a per-renderer ItemCache. The cache can't be used for the size hints needed for layouts (as the word break changes as is used for shaping). The line breaking is also not re-used, but nevertheless this should reduce the amount of time spent rendering text. cc #10087 cc #2306
tronical
changed the title
tronical
force-pushed
the
simon/text-cache
branch
from
09b3df3 to
ebce871
Compare
Instead of a Rc<RefCell<Option<>>> make it possible to obtain a RefMut from the ItemCache and use that in the guard instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of shaping is cached in a per-renderer ItemCache. The cache
can't be used for the size hints needed for layouts (as the word break
changes as is used for shaping). The line breaking is also not re-used,
but nevertheless this should reduce the amount of time spent rendering
text.
cc #10087
cc #2306