fix: handle inconsistent safety car#260
Merged
slowlydev merged 3 commits intoslowlydev:developfrom May 8, 2025
Merged
Conversation
|
@AbsentData is attempting to deploy a commit to the f1-dash Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
slowlydev
approved these changes
May 8, 2025
Owner
slowlydev
left a comment
slowlydev
left a comment
There was a problem hiding this comment.
made a small adjustment so we show all safety cars, in cease one of them could be the medical car, else lgtm, thanks
Contributor
Author
|
Makes sense. I originally did that but I preferred the code the other way and the data never showed any overlap, but this is probably better just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F1 is inconsistent with which car is the safety car (241, 242, or 243), this handles that by showing whichever car has a non-zero z value. There is never any overlap between those cars (at least since Spain last year since that's as far back as my data goes), so that doesn't need to be worried about, and through the testing I've done it seems to consistently work.