refactor(server): replace transpose with match for request error hand…#358
Open
Alarak-Alex wants to merge 1 commit intoslowtec:mainfrom
Open
refactor(server): replace transpose with match for request error hand…#358Alarak-Alex wants to merge 1 commit intoslowtec:mainfrom
Alarak-Alex wants to merge 1 commit intoslowtec:mainfrom
Conversation
…ling Refactor request processing logic in tcp, rtu, and rtu_over_tcp modules to use explicit match expressions instead of transpose. Improve error handling clarity by continuing the loop on error instead of returning immediately.
sahil-boom
reviewed
Dec 11, 2025
| continue; | ||
| } | ||
| None => { | ||
| log::debug!("TCP socket has been closed"); |
There was a problem hiding this comment.
I think this log messaged should be "Stream has finished"
Member
Why do you want to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ling
Refactor request processing logic in tcp, rtu, and rtu_over_tcp modules to use explicit match expressions instead of transpose. Improve error handling clarity by continuing the loop on error instead of returning immediately.