Skip to content

Hpe 3par add collect performance interface#789

Merged
wisererik merged 16 commits intosodafoundation:masterfrom
gh-ca:hpe_3par
May 17, 2022
Merged

Hpe 3par add collect performance interface#789
wisererik merged 16 commits intosodafoundation:masterfrom
gh-ca:hpe_3par

Conversation

@yuanyu-ghca
Copy link
Contributor

What this PR does / why we need it:
add collect performance interface

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #789 (e6d1c17) into master (3d0c190) will increase coverage by 0.02%.
The diff coverage is 71.02%.

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   70.77%   70.80%   +0.02%     
==========================================
  Files         181      181              
  Lines       19547    19865     +318     
  Branches     2921     2981      +60     
==========================================
+ Hits        13834    14065     +231     
- Misses       4797     4855      +58     
- Partials      916      945      +29     
Impacted Files Coverage Δ
delfin/drivers/hpe/hpe_3par/rest_handler.py 35.43% <27.27%> (-0.78%) ⬇️
delfin/drivers/utils/tools.py 68.96% <58.82%> (-1.75%) ⬇️
delfin/drivers/hpe/hpe_3par/component_handler.py 74.38% <66.34%> (-4.09%) ⬇️
delfin/drivers/hpe/hpe_3par/ssh_handler.py 80.00% <84.00%> (+1.13%) ⬆️
delfin/drivers/hpe/hpe_3par/hpe_3parstor.py 86.66% <88.88%> (+0.09%) ⬆️
delfin/drivers/hpe/hpe_3par/consts.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 94.65% <0.00%> (+1.01%) ⬆️

joseph-v
joseph-v previously approved these changes Jan 5, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use warning insteand.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

joseph-v
joseph-v previously approved these changes Apr 25, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 175fb10 into sodafoundation:master May 17, 2022
@yuanyu-ghca yuanyu-ghca deleted the hpe_3par branch July 27, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments