Skip to content

emc unity support performance#792

Merged
wisererik merged 38 commits intosodafoundation:masterfrom
gh-ca:unity_1123
May 18, 2022
Merged

emc unity support performance#792
wisererik merged 38 commits intosodafoundation:masterfrom
gh-ca:unity_1123

Conversation

@tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #792 (7aa492a) into master (175fb10) will decrease coverage by 0.04%.
The diff coverage is 67.15%.

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   70.78%   70.73%   -0.05%     
==========================================
  Files         181      181              
  Lines       19865    20104     +239     
  Branches     2981     3037      +56     
==========================================
+ Hits        14061    14221     +160     
- Misses       4856     4912      +56     
- Partials      948      971      +23     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/unity/rest_handler.py 46.31% <33.33%> (-2.54%) ⬇️
delfin/drivers/dell_emc/unity/unity.py 67.56% <67.24%> (-0.90%) ⬇️
delfin/drivers/dell_emc/unity/consts.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 94.40% <0.00%> (+0.76%) ⬆️

joseph-v
joseph-v previously approved these changes Jan 6, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanjiangyu-ghca tanjiangyu-ghca changed the title emc unity add performance data emc unity support performance Jan 13, 2022
def get_latest_perf_timestamp(self, context):
latest_time = 0
page = 1
results = self.rest_handler.get_history_metrics(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I obtain the maximum performance collection time of a device when the value of page is 1?

Copy link
Contributor Author

@tanjiangyu-ghca tanjiangyu-ghca Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,the performance data is Descending order,the latest data in the first page

joseph-v
joseph-v previously approved these changes Apr 25, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joseph-v
joseph-v previously approved these changes Apr 28, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit b92804f into sodafoundation:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments