Skip to content

add Pure mapping#820

Merged
wisererik merged 13 commits intosodafoundation:masterfrom
gh-ca:pure-mapping
May 18, 2022
Merged

add Pure mapping#820
wisererik merged 13 commits intosodafoundation:masterfrom
gh-ca:pure-mapping

Conversation

@zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #820 (f75315d) into master (21afd81) will increase coverage by 0.10%.
The diff coverage is 95.40%.

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   70.75%   70.86%   +0.10%     
==========================================
  Files         182      182              
  Lines       20297    20384      +87     
  Branches     3073     3087      +14     
==========================================
+ Hits        14362    14445      +83     
- Misses       4952     4954       +2     
- Partials      983      985       +2     
Impacted Files Coverage Δ
delfin/drivers/pure/flasharray/pure_flasharray.py 85.54% <95.00%> (+2.92%) ⬆️
delfin/drivers/pure/flasharray/consts.py 100.00% <100.00%> (ø)
delfin/drivers/pure/flasharray/rest_handler.py 38.75% <100.00%> (+4.96%) ⬆️

Copy link
Contributor

@qinwang-murphy qinwang-murphy Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personality = host.get('personality').lower() if host.get('personality') else **
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been modified

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit effad04 into sodafoundation:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments