Conversation
joseph-v
reviewed
Apr 22, 2022
|
|
||
|
|
||
| def fake_update_access_info(self, context, access_info): | ||
| def fake_update_access_info(self, context): |
Collaborator
There was a problem hiding this comment.
You need to update caller of this function too. (Please check, file delfin/tests/unit/api/v1/test_access_info.py)
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 70.57% 70.59% +0.02%
==========================================
Files 180 180
Lines 18825 18825
Branches 2769 2769
==========================================
+ Hits 13285 13289 +4
+ Misses 4695 4694 -1
+ Partials 845 842 -3
|
skdwriting
added
SODACODE2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nikita15p nikita15p@gmail.com
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #871Special notes for your reviewer:
Special thanks to @SODACON