Comment updated for Fakedriver method - for issue #888#893
Merged
skdwriting merged 3 commits intosodafoundation:masterfrom Apr 28, 2022
Merged
Comment updated for Fakedriver method - for issue #888#893skdwriting merged 3 commits intosodafoundation:masterfrom
skdwriting merged 3 commits intosodafoundation:masterfrom
Conversation
Added comments explaining why Fakedriver methods are empty : add_trap_config remove_trap_config parse_alert clear_alert
joseph-v
reviewed
Apr 27, 2022
Collaborator
There was a problem hiding this comment.
CI is failed (E261 at least two spaces before inline comment), please fix.
Contributor
Author
There was a problem hiding this comment.
Updated spaces before inline comments. Thanks for guiding!
Added two spaces before comments
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 70.48% 70.47% -0.01%
==========================================
Files 181 181
Lines 19055 19055
Branches 2812 2812
==========================================
- Hits 13430 13429 -1
Misses 4756 4756
- Partials 869 870 +1
|
joseph-v
added
SODACODE2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added comments explaining why Fakedriver methods are empty :
add_trap_config
remove_trap_config
parse_alert
clear_alert
Which issue this PR fixes:
fixes #888
Special notes for your reviewer:
Thank you!
SODACODE2022
Release note:
NONE