update in this swagger.yaml#897
Merged
sushanthakumar merged 2 commits intosodafoundation:masterfrom May 2, 2022
muniraj321:patch-6
Merged
update in this swagger.yaml#897sushanthakumar merged 2 commits intosodafoundation:masterfrom muniraj321:patch-6
sushanthakumar merged 2 commits intosodafoundation:masterfrom
muniraj321:patch-6
Conversation
update name and description in this file should be disk-> get/v1/disks
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
==========================================
+ Coverage 70.47% 70.49% +0.01%
==========================================
Files 181 181
Lines 19055 19055
Branches 2812 2812
==========================================
+ Hits 13429 13432 +3
+ Misses 4756 4755 -1
+ Partials 870 868 -2
|
joseph-v
added
SODACODE2022
Collaborator
|
LGTM |
Collaborator
|
#SODA-PR-ACCEPTED |
sushanthakumar
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update name and description in this file should be disk-> get/v1/disks
GET v1/disks is showing "ports" instead of "disks"
and also in description it was showing ports
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: