Skip to content

Add readResponseTime/writeResponseTime for storage and volume metrics, and add metric constants.#908

Merged
wisererik merged 1 commit intosodafoundation:masterfrom
JiuyunZhao:jiuyunzhao_new_metrics_20220630
Jun 14, 2022
Merged

Add readResponseTime/writeResponseTime for storage and volume metrics, and add metric constants.#908
wisererik merged 1 commit intosodafoundation:masterfrom
JiuyunZhao:jiuyunzhao_new_metrics_20220630

Conversation

@JiuyunZhao
Copy link
Contributor

Add readResponseTime/writeResponseTime for storage and volume metrics, and add metric constants.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@JiuyunZhao JiuyunZhao force-pushed the jiuyunzhao_new_metrics_20220630 branch from c1ada26 to a12548f Compare June 14, 2022 08:46
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #908 (a12548f) into master (2fba071) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   71.27%   71.36%   +0.09%     
==========================================
  Files         182      182              
  Lines       21327    21398      +71     
  Branches     3264     3271       +7     
==========================================
+ Hits        15200    15271      +71     
  Misses       5096     5096              
  Partials     1031     1031              
Impacted Files Coverage Δ
delfin/api/schemas/storage_capabilities_schema.py 100.00% <ø> (ø)
delfin/drivers/fake_storage/__init__.py 94.65% <ø> (ø)
delfin/common/constants.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit ee56a1d into sodafoundation:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments