Skip to content

add macro_san storge#945

Merged
joseph-v merged 2 commits intosodafoundation:masterfrom
gh-ca:macro
Nov 22, 2022
Merged

add macro_san storge#945
joseph-v merged 2 commits intosodafoundation:masterfrom
gh-ca:macro

Conversation

@zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #945 (3ebd6d8) into master (ca0ba06) will decrease coverage by 0.13%.
The diff coverage is 68.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   71.49%   71.35%   -0.14%     
==========================================
  Files         183      187       +4     
  Lines       21938    23067    +1129     
  Branches     3335     3508     +173     
==========================================
+ Hits        15684    16459     +775     
- Misses       5183     5491     +308     
- Partials     1071     1117      +46     
Impacted Files Coverage Δ
delfin/drivers/macro_san/ms/macro_ssh_client.py 16.41% <16.41%> (ø)
delfin/drivers/utils/ssh_client.py 16.52% <50.00%> (-0.29%) ⬇️
delfin/drivers/macro_san/ms/ms_handler.py 65.08% <65.08%> (ø)
delfin/drivers/macro_san/ms/ms_stor.py 93.22% <93.22%> (ø)
delfin/common/constants.py 100.00% <100.00%> (ø)
delfin/drivers/macro_san/ms/consts.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit a43a376 into sodafoundation:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments