Conversation
sync code from upstream
added 11 commits
March 4, 2019 15:38
added 2 commits
March 26, 2019 10:10
# Conflicts: # pom.xml # tracer-core/src/main/java/com/alipay/common/tracer/core/span/CommonSpanTags.java
Closed
glmapper
added
enhancement
guanchao-yang
approved these changes
Apr 3, 2019
ujjboy
requested changes
Apr 3, 2019
| <dependency> | ||
| <groupId>com.alibaba</groupId> | ||
| <artifactId>dubbo</artifactId> | ||
| <version>2.6.0</version> |
Contributor
Author
There was a problem hiding this comment.
这个2.6.0 是为了？
这个和 Dubbo 插件依赖没有关系。这是 SOFARPC 的依赖版本
| @@ -0,0 +1,145 @@ | |||
| ## 使用 SOFATracer 集成 Dubbo 埋点 | |||
added 2 commits
April 3, 2019 21:55
caojie09
reviewed
Apr 4, 2019
| <dependency> | ||
| <groupId>org.apache.dubbo</groupId> | ||
| <artifactId>dubbo</artifactId> | ||
| <version>2.7.0</version> |
There was a problem hiding this comment.
写成provided就好了吧，如果有人要用sofa-tracer-dubbo-plugin，那他肯定是dubbo环境，如果不是dubbo环境误引入，我们也有conditionOnClass保证不报错，没必要把这个依赖带出去。
caojie09
reviewed
Apr 4, 2019
|
|
||
| * 在工程模块的 pom 文件中添加 SOFATracer 依赖 | ||
|
|
||
| ```xml |
Contributor
Author
There was a problem hiding this comment.
文件格式有问题，前面没必要空两个空格。
属于子条目下，空格看起来层次更清晰点
caojie09
approved these changes
Apr 4, 2019
ujjboy
approved these changes
Apr 4, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
support dubbo
Result:
Fixes #102