Skip to content

optimized server received logic #289

Merged
guanchao-yang merged 2 commits intosofastack:3.xfrom
glmapper:fix-server-spancontext
Nov 6, 2019
Merged

optimized server received logic #289
guanchao-yang merged 2 commits intosofastack:3.xfrom
glmapper:fix-server-spancontext

Conversation

@glmapper
Copy link
Contributor

when in the sr stage, a new span should be built by the SofaTracer instance.

At present, we construct spanContext and Span directly through the constructor, which adds complexity to the span relationship. The API provided in SofaTracerSpanBuilder solves this problem.

Copy link
Contributor

@xzchaoo xzchaoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@guanchao-yang guanchao-yang merged commit de8ded5 into sofastack:3.x Nov 6, 2019
@glmapper glmapper deleted the fix-server-spancontext branch November 6, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments