Skip to content

feat: Remove native-stack v5 from screens repo #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmichalikk merged 2 commits into from
Dec 1, 2025
Merged

feat: Remove native-stack v5 from screens repo #3433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c9f539
Remove native-stack v5 from screens repo
kmichalikk Nov 28, 2025
f8aa19f
feat: Comment out TestScreenAnimationV5 (#3436)
kmichalikk Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/src/tests/TestScreenAnimationV5.tsx
View file
Open in desktop
Copy link
Member

@kkafar kkafar Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test case even work? I think that we never downstreamed this feature to react-navigation. There was a PR from @maciekstosio, but it has not been completed.

Please verify whether we have ticket for downstreaming it (I think I recently saw one on the board, it could have been a draft so it won't be visible in labs issues). If not -> create one.

Now, regarding this test -> if it does not work, it should be "suspended". I'd recommend commenting it out in index file, so that it is not loaded or marking it somehow as "disabled" (can be done in separate, follow up PR).

Copy link
Contributor Author

@kmichalikk kmichalikk Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the PR:
react-navigation/react-navigation#12225

Copy link
Contributor Author

@kmichalikk kmichalikk Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/software-mansion/react-native-screens-labs/issues/610

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { GestureHandlerRootView } from 'react-native-gesture-handler';
import {
NativeStackNavigationProp,
createNativeStackNavigator,
} from 'react-native-screens/native-stack'
} from '@react-navigation/native-stack'
import { GestureDetectorProvider } from 'react-native-screens/gesture-handler';

type StackParamList = {
Expand Down
4 changes: 3 additions & 1 deletion apps/src/tests/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ export { default as Test3379 } from './Test3379';
export { default as Test3422 } from './Test3422';
export { default as Test3425 } from './Test3425';
export { default as TestScreenAnimation } from './TestScreenAnimation';
export { default as TestScreenAnimationV5 } from './TestScreenAnimationV5';
// The following test was meant to demo the "go back" gesture using Reanimated
// but the associated PR in react-navigation is currently put on hold
// export { default as TestScreenAnimationV5 } from './TestScreenAnimationV5';
export { default as TestHeader } from './TestHeader';
export { default as TestPreload } from './TestPreload';
export { default as TestActivityStateProgression } from './TestActivityStateProgression';
Expand Down
867 changes: 0 additions & 867 deletions native-stack/README.md
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions native-stack/package.json
View file
Open in desktop

This file was deleted.

12 changes: 7 additions & 5 deletions src/gesture-handler/constraints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import { ScreenTransition } from 'react-native-reanimated';
import {
ScreenTransition,
AnimatedScreenTransition,
GoBackGesture,
PanGestureHandlerEventPayload,
} from '../native-stack/types';
} from 'react-native-reanimated';
import { AnimationForGesture } from './defaults';
import { GestureUpdateEvent } from 'react-native-gesture-handler';
import {
GestureUpdateEvent,
PanGestureHandlerEventPayload,
} from 'react-native-gesture-handler';

const SupportedGestures = [
const SupportedGestures: GoBackGesture[] = [
'swipeRight',
'swipeLeft',
'swipeDown',
Expand Down
9 changes: 0 additions & 9 deletions src/native-stack/contexts/GHContext.tsx
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions src/native-stack/index.tsx
View file
Open in desktop

This file was deleted.

96 changes: 0 additions & 96 deletions src/native-stack/navigators/createNativeStackNavigator.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading