fix: prevent parent expansion by skipping width/height setting to 100% on absolute SVG#2752
Merged
jakex7 merged 1 commit intosoftware-mansion:mainfrom Aug 26, 2025
Conversation
…% on absolute SVG
jakex7
approved these changes
Aug 26, 2025
Member
jakex7
left a comment
jakex7
left a comment
There was a problem hiding this comment.
Please fix the title as we automatically generate the changelog from it
kacperzolkiewski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue: #2689
In the SVG component when we do not pass
widthandheightprops, we set them to 100%. This caused problems when position is set to absolute because the SVG would expand beyond its parent. I added an extra check to only set width/height to 100% ifposition !== 'absolute'.Test Plan
Run the example from issue: #2689 and check if Views are filled properly
Compatibility
Checklist