Curl backend should set user agent #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
May 12, 2025
| int sttp_curl_setopt_pointer(CURL *curl, CURLoption opt, void* arg) {return curl_easy_setopt(curl, opt, arg); } | ||
|
|
||
| const char* sttp_curl_get_version() { | ||
| return curl_version_info(CURLVERSION_NOW)->version; |
Contributor
Author
There was a problem hiding this comment.
Added a FFI method instead of defining the full struct for what curl_version_info returns.
keynmol
commented
May 12, 2025
| } | ||
| } | ||
|
|
||
| private lazy val curlUserAgent = "sttp-curl/" + fromCString(CCurl.getVersion()) |
Contributor
Author
There was a problem hiding this comment.
sttp-curl/8.7.1 is what I get on my machine
Right({
"method": "GET",
"protocol": "https",
"host": "echo.free.beeceptor.com",
"path": "/",
"ip": "195.26.120.14:57556",
"headers": {
"Host": "echo.free.beeceptor.com",
"User-Agent": "sttp-curl/8.7.1",
"Accept": "*/*",
"Accept-Encoding": "gzip, deflate"
},
"parsedQueryParams": {}
})
keynmol
commented
May 12, 2025
Comment on lines
+96
to
+99
| curl.option( | ||
| UserAgent, | ||
| userAgent | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I think it's a reasonable default to always set the user agent – user still can circumvent that by using an empty string in the headers.
Member
|
Looks good, thanks! |
Contributor
Author
|
@adamw would it be possible to get a patch release? I see 4.0.5 was cutoff just before this commit |
Member
|
@keynmol yes, sorry, I forgot to push the tag 🤦 doing that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reasonable default user agent for the curl native backend, because it's a better default behaviour, see explanation below.
Consider this simple usage of sttp:
Notice how on JVM,
User-Agentis added automatically by the client implementation.Now, if you run this on Native:
There is no user agent, because libcurl does not add it by default.
Apparently there are some hosts that prohibit empty user agents – one of them being Scaladex!
Lack of user agent on native prevents parity between JVM and Native usage of sttp.