Skip to content

Conversation

@threeseed
Copy link
Contributor

No description provided.

@threeseed threeseed force-pushed the armeria-auth-proxy branch from 2e091e7 to 8347cf7 Compare May 15, 2025 03:35
@adamw
Copy link
Member

adamw commented May 15, 2025

Ah, asJavaProxySelector indeed doesn't take into account authentication. Do you think it's possible to support onlyProxyHosts / nonProxyHosts in your code? Also, is it correct to always add proxy config, even if none is specified in the backend options?

@threeseed
Copy link
Contributor Author

threeseed commented May 15, 2025

a) It works with your existing asJavaProxySelector code which already handles onlyProxyHosts/nonProxyHosts.

b) ProxyConfig.DIRECT means no proxy as described here so should be fine.

c) Also for reference I tried other approaches i.e. Java.net.Authenticator and a decorator that adds the Auth headers but neither worked.

@adamw
Copy link
Member

adamw commented May 15, 2025

Ok, fair enough, let's merge this then. Thanks! :)

@adamw adamw merged commit 68e158d into softwaremill:master May 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants