Skip to content

fix: use fresh wallet to exercise ata creation in full demo#275

Merged
dev-jodee merged 1 commit intosolana-foundation:mainfrom
rajgoesout:fix/full-demo-ata-creation
Jan 6, 2026
Merged

fix: use fresh wallet to exercise ata creation in full demo#275
dev-jodee merged 1 commit intosolana-foundation:mainfrom
rajgoesout:fix/full-demo-ata-creation

Conversation

@rajgoesout
Copy link
Contributor

@rajgoesout rajgoesout commented Dec 29, 2025

Important

Use a fresh wallet for token transfer in full-demo.ts to ensure ATA creation is tested.

  • Behavior:
    • In createInstructions in full-demo.ts, replace destinationKeypair.address with a new address from generateKeyPairSigner() for token transfer.
    • Ensures ATA creation is tested by using a fresh wallet for the token destination.
  • Imports:
    • Add generateKeyPairSigner to imports in full-demo.ts.

This description was created by Ellipsis for f792cb6. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to f792cb6 in 28 seconds. Click for details.
  • Reviewed 26 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/getting-started/demo/client/src/full-demo.ts:4
  • Draft comment:
    Import added: generateKeyPairSigner. Ensure it returns the proper KeyPairSigner that matches downstream usage.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. examples/getting-started/demo/client/src/full-demo.ts:102
  • Draft comment:
    Using a freshly generated wallet (tokenDestination) for testing ATA creation. Consider logging its address for easier debugging.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_FypSSzMSbLjLNUx5

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@amilz amilz self-assigned this Jan 5, 2026
@dev-jodee dev-jodee requested a review from amilz January 5, 2026 16:31
@amilz
Copy link
Contributor

amilz commented Jan 5, 2026

Depends on #267 to be released. Will hold PR for now.

Copy link
Contributor

@dev-jodee dev-jodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can now merge, since we have beta (pre release) package

@dev-jodee dev-jodee merged commit 818d8bd into solana-foundation:main Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants