fix: use fresh wallet to exercise ata creation in full demo#275
Merged
dev-jodee merged 1 commit intosolana-foundation:mainfrom Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to f792cb6 in 28 seconds. Click for details.
- Reviewed
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/getting-started/demo/client/src/full-demo.ts:4
- Draft comment:
Import added: generateKeyPairSigner. Ensure it returns the proper KeyPairSigner that matches downstream usage. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. examples/getting-started/demo/client/src/full-demo.ts:102
- Draft comment:
Using a freshly generated wallet (tokenDestination) for testing ATA creation. Consider logging its address for easier debugging. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_FypSSzMSbLjLNUx5
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
|
Depends on #267 to be released. Will hold PR for now. |
dev-jodee
approved these changes
Jan 6, 2026
Contributor
dev-jodee
left a comment
There was a problem hiding this comment.
Can now merge, since we have beta (pre release) package
amilz
pushed a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Use a fresh wallet for token transfer in
full-demo.tsto ensure ATA creation is tested.createInstructionsinfull-demo.ts, replacedestinationKeypair.addresswith a new address fromgenerateKeyPairSigner()for token transfer.generateKeyPairSignerto imports infull-demo.ts.This description was created by
for f792cb6. You can customize this summary. It will automatically update as commits are pushed.