Skip to content

feat(cli): solve the no studio flag#379

Merged
lgalabru merged 2 commits intosolana-foundation:mainfrom
zsh28:solve-no-studio
Oct 20, 2025
Merged

feat(cli): solve the no studio flag#379
lgalabru merged 2 commits intosolana-foundation:mainfrom
zsh28:solve-no-studio

Conversation

@zsh28
Copy link
Copy Markdown
Contributor

@zsh28 zsh28 commented Oct 19, 2025

Problem:

The --no-studio flag only affected which URL was displayed in the TUI, but the HTTP server always served studio static files regardless of the flag.

Solution:

• Modified start_subgraph_and_explorer_server() to accept an enable_studio parameter
• Conditionally add the studio static files service only when !cmd.no_studio
• The HTTP server still runs (for GraphQL endpoints), but studio UI returns 404 when --no-studio is used

Copy link
Copy Markdown
Collaborator

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zsh28!

Copy link
Copy Markdown
Collaborator

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @zsh28 🙏

@lgalabru
Copy link
Copy Markdown
Collaborator

@zsh28 could you run

cargo +nightly fmt --all

and push your changes? thanks!

@zsh28
Copy link
Copy Markdown
Contributor Author

zsh28 commented Oct 20, 2025

@zsh28 could you run

cargo +nightly fmt --all

and push your changes? thanks!

on it!

@zsh28
Copy link
Copy Markdown
Contributor Author

zsh28 commented Oct 20, 2025

@lgalabru done!

@lgalabru lgalabru merged commit 73a1955 into solana-foundation:main Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants