Merged
Conversation
# Conflicts: # crates/core/src/rpc/full.rs
lgalabru
force-pushed
the
feat/scenarios
branch
from
17cf86e to
95333ce
Compare
lgalabru
force-pushed
the
feat/scenarios
branch
from
413f40e to
bd48ff4
Compare
MicaiahReid
requested changes
Oct 29, 2025
| lookup.add_collection(metadata); | ||
| gql_schema.replace(new_dynamic_schema(lookup.clone())); | ||
|
|
||
| let console_url = format!("{}/accounts", config.studio_url.clone()); |
Collaborator
There was a problem hiding this comment.
Hmm, don't know if I love /accounts, cause we could still be indexing events
| /// IDL for the account structure - defines all available fields and types | ||
| pub idl: Idl, | ||
| /// How to determine the account address | ||
| pub address: AccountAddress, |
Collaborator
There was a problem hiding this comment.
This AccountAddress type seems unnecessary to me - what am I missing? I'd think it could just be address.
The protocol with this IDL will be deployed to an address, and the accounts it generates will have their PDA derivations defined in the IDL.
I'm not sure of protocols themselves being deployed to PDAs.
crates/core/src/surfnet/locker.rs
Outdated
| ) -> SurfpoolResult<KeyedProfileResult> { | ||
| let signature = transaction.signatures[0]; | ||
|
|
||
| // Can we avoid this write? |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Can we avoid this write? |
How? Notify subscribers sooner?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.