Skip to content

fix: representation of timestamp in getTransaction rpc method #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgalabru merged 1 commit into from
Nov 7, 2025
Merged

fix: representation of timestamp in getTransaction rpc method #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/core/src/rpc/full.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1821,7 +1821,7 @@ impl Full for SurfpoolFullRpc {
svm_reader
.blocks
.get(&slot)
.map(|block| (block.block_time / 1000) as UnixTimestamp)
.map(|block| (block.block_time / 1_000) as UnixTimestamp)
});
Ok(block_time)
})
Expand Down
4 changes: 2 additions & 2 deletions crates/core/src/surfnet/locker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use solana_client::{
RpcLogsResponse, RpcTokenAccountBalance,
},
};
use solana_clock::{Clock, Slot};
use solana_clock::{Clock, Slot, UnixTimestamp};
use solana_commitment_config::{CommitmentConfig, CommitmentLevel};
use solana_epoch_info::EpochInfo;
use solana_hash::Hash;
Expand Down Expand Up @@ -737,7 +737,7 @@ impl SurfnetSvmLocker {
let block_time = svm_reader
.blocks
.get(&slot)
.map(|b| b.block_time)
.map(|b| (b.block_time / 1_000) as UnixTimestamp)
.unwrap_or(0);
let encoded = transaction_with_status_meta.encode(
config.encoding.unwrap_or(UiTransactionEncoding::JsonParsed),
Expand Down