Skip to content

fix: capture context slot consistently in getSignatureStatuses RPC #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MicaiahReid merged 1 commit into from
Nov 13, 2025
Merged

fix: capture context slot consistently in getSignatureStatuses RPC #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions crates/core/src/rpc/full.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,14 +1469,16 @@ impl Full for SurfpoolFullRpc {
let remote_client = remote_ctx.map(|(r, _)| r);

Box::pin(async move {
// Capture the context slot once at the beginning to ensure consistency
// across all signature lookups, even if the slot advances during the loop
let context_slot = svm_locker.get_latest_absolute_slot();

let mut responses = Vec::with_capacity(signatures.len());
let mut last_latest_absolute_slot = 0;
for signature in signatures.into_iter() {
let res = svm_locker
.get_transaction(&remote_client, &signature, get_default_transaction_config())
.await?;

last_latest_absolute_slot = svm_locker.get_latest_absolute_slot();
let mut status = res.map_some_transaction_status();
if let Some(confirmation_status) =
status.as_ref().and_then(|s| s.confirmation_status.as_ref())
Expand All @@ -1491,7 +1493,7 @@ impl Full for SurfpoolFullRpc {
responses.push(status);
}
Ok(RpcResponse {
context: RpcResponseContext::new(last_latest_absolute_slot),
context: RpcResponseContext::new(context_slot),
value: responses,
})
})
Expand Down Expand Up @@ -2596,6 +2598,12 @@ mod tests {
);
setup.process_txs(txs.clone()).await;

// Capture the expected slot before the call to verify context slot consistency
let current_slot = setup
.context
.svm_locker
.with_svm_reader(|svm_reader| svm_reader.get_latest_absolute_slot());

// fetch while transactions are still in processed status
{
let res = setup
Expand Down Expand Up @@ -2631,6 +2639,13 @@ mod tests {
.await
.unwrap();

// Verify context slot is captured at the beginning of the call
assert_eq!(
res.context.slot,
current_slot + 1,
"Context slot should be captured at the beginning of the call, not after lookups"
);

assert_eq!(
res.value
.iter()
Expand Down