feat: add list_plugins admin RPC and remove rpc_addr admin RPC method from trait#408
Conversation
MicaiahReid
left a comment
There was a problem hiding this comment.
As I was reviewing this PR, I realized the rpc_addr method is quite a silly one 😂
You need to know the network's rpc address in order to fetch it's rpc address via rpc... so why do we need the method? hahaha
Would you be able to remove the changes from that method, and that method from the AdminRpc trait completely?
When put that way, it does sound funny. 😹 . Sure I will remove all instances of the method and the structure field I added to tests and elsewhere! |
|
@MicaiahReid I have added the changes you requested. Please take a look! |
MicaiahReid
left a comment
There was a problem hiding this comment.
LGTM, thanks @0xsouravm!!
Changes:
list_plugins(meta)RPC method definitionListPluginsvariantplugin_uuid_map: HashMap<Uuid, usize>into `plugin_map: HashMap<Uuid, (usize, String)>to store plugin names along with UUID for efficient listingrpc_addrmethod from the traitReference: #330