fix(simnet): improve error handling and port availability checks#439
Merged
MicaiahReid merged 3 commits intosolana-foundation:mainfrom Dec 2, 2025
Merged
Conversation
- Replace process exit with event-based error propagation in simnet thread - Add port availability validation before starting RPC and WebSocket servers - Extract port checking logic into reusable check_port_availability function - Print error messages to stderr for better visibility when ports are in use - Remove unnecessary sleep and direct process exit calls - Provide clearer error messages when address binding fails - Allow graceful error handling through the event channel instead of abrupt termination
Contributor
Author
|
@MicaiahReid ser can you please check this PR? thank you! |
MicaiahReid
approved these changes
Dec 2, 2025
Collaborator
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
This is awesome, thanks @Pawank06!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces safer and more graceful error handling in the Simnet threading flow:
Before:
After:
fixes: #438