Added panic unwinding error handling to give appropriate errors message#532
Merged
MicaiahReid merged 2 commits intosolana-foundation:mainfrom Feb 27, 2026
Merged
Conversation
MicaiahReid
approved these changes
Feb 26, 2026
Collaborator
MicaiahReid
left a comment
There was a problem hiding this comment.
LGTM, thanks @0xzrf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a panic in the
surfpool completion bashcommand caused by callingOption::unwrap()on aNonevalue. Instead of crashing, the command now returns an appropriate error message and exits with a non-zero status code.Closes #531
🔍 What Changed
unwrap()with proper error handling.🧪 How to Test
Run:
Context
The original issue described a panic when running the bash completion command due to an unchecked Option::unwrap(). This caused an abrupt crash without useful feedback to the user. Handling this case explicitly improves stability and user experience. (#531)
Notes
This fix does not add any new features; it improves error safety and observability.
Helps maintain a more robust CLI surface in the Surfpool tool.