added fix to the ls command when txtx.yaml file doesn't exist#535
Merged
MicaiahReid merged 2 commits intosolana-foundation:mainfrom Feb 26, 2026
Merged
added fix to the ls command when txtx.yaml file doesn't exist#535MicaiahReid merged 2 commits intosolana-foundation:mainfrom
MicaiahReid merged 2 commits intosolana-foundation:mainfrom
Conversation
Collaborator
|
Thanks for the PR, @0xzrf! I changed slightly to more generally improve the error displaying. Will merge once CI runs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running
surfpool lson a folder that doesn't have txtx.yaml file in it(or even provided in cli) doesn't output anythingSteps to Reproduce
surfpool lson a folder that doesn't have txtx.yamlCurrent Behavior
The process exits with a non-zero value, but doesn't log anything that might be helpful to the user
Expected Behavior
The command should:
What this PR Solves
This isn't solving a huge problem, but it's still a contribution, as I see it doesn't help the user to know what went wrong. This PR aims to add a simple error handling to the
surfpool_cli/src/cli/mod.rs/FN:handle_list_commandto show error when something goes wrong while executing thesurfpool lscommand