fix: order signatures for getSignaturesForAddress#546
Merged
MicaiahReid merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
MicaiahReid
changed the title
lgalabru
reviewed
Mar 5, 2026
| .unwrap_or(usize::MAX); | ||
| b_pos.cmp(&a_pos) | ||
| }) | ||
| }) |
Collaborator
There was a problem hiding this comment.
I don't know how hot this codepath is, but it looks like we're doing a lot of cloning / copy.
When we started building Surfpool, we had limited resources and our core constraint was time to market, joining Foundation is removing some of this stress - I think we can now spend a few additional cycles on shipping optimized / memory-efficient routines.
Collaborator
Author
There was a problem hiding this comment.
Fair enough! All clones were of Option<u64>, which isn't too bad, but agreed on updating our general approach to start optimizing. Pushed a fix! 35a1833
lgalabru
approved these changes
Mar 5, 2026
Collaborator
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
LGTM, thanks @MicaiahReid!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.