fix: correct bool logic in get_multiple_accounts from remote#559
Merged
MicaiahReid merged 7 commits intomainfrom Mar 6, 2026
Merged
fix: correct bool logic in get_multiple_accounts from remote#559MicaiahReid merged 7 commits intomainfrom
MicaiahReid merged 7 commits intomainfrom
Conversation
MicaiahReid
force-pushed
the
fix/get-multiple-accounts-logic
branch
from
f389962 to
998b95e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduced a subtle bug when fetching multiple accounts from the remote:
||->&&) was preventing some accounts from getting fetchedzipamong two vecsThis PR introduced loading accounts on startup when there's a
test.validator.accountprovided in an Anchor.toml. However, it shouldn't pull those accounts in if there's aTest.tomlprovided as well (Test.tomloverrides)Both bugs are fixed, with tests added