fix: enable register-tracing feature by default in cli#606
Merged
MicaiahReid merged 1 commit intosolana-foundation:mainfrom Apr 1, 2026
Merged
fix: enable register-tracing feature by default in cli#606MicaiahReid merged 1 commit intosolana-foundation:mainfrom
MicaiahReid merged 1 commit intosolana-foundation:mainfrom
Conversation
The feature was listed in core's defaults but the workspace dependency uses default-features = false, so it was never actually enabled. Move it to the cli crate's default features where it takes effect and remove it from core's defaults to avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @MicaiahReid, sorry about putting register-tracing in the wrong place - I added it to core's default features but the workspace dep uses default-features = false, so it was never actually enabled. Fixed it now by moving it to the cli defaults instead.