Conversation
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Trimmed down from https://github.com/solana-program/token-2022/blob/main/Makefile. Added todo's for remaining CI/CD checks in PR description.
grod220
force-pushed
the
makefile-migration
branch
17 times, most recently
from
275cdf9 to
b0a93d5
Compare
grod220
force-pushed
the
makefile-migration
branch
from
b0a93d5 to
b025074
Compare
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just nits on the README, the rest looks great to me, with Pete's comments applied
| # TODO program_test is too unreliable to run in ci | ||
| # the tests are fine, but the underlying transport panics frequently, even with `--test-threads 1` | ||
| # we exclude these tests for now because mollusk tests at least provide decent ci coverage | ||
| # in the future if we cannot debug the cause we should move program_test to a different execution engine | ||
| test-program: ARGS = --features bpf-entrypoint -- --skip program_test | ||
|
|
||
| test-%: | ||
| SBF_OUT_DIR=$(PWD)/target/deploy cargo $(nightly) test --manifest-path $(call make-path,$*)/Cargo.toml $(ARGS) |
There was a problem hiding this comment.
Note update. The current workflow specifically skips program_test. Copied over the code comment and aligned with previous flow.
There was a problem hiding this comment.
We use program-test in almost every other repo, so I'm not sure what the comment means, but we can fix it in follow-up work
|
@joncinque needs your final review, but also manual editing of the required checks on this repo 🙏 |
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
3 participants
Blocked by solana-program/actions#16
Mirrors work done in solana-program/token-2022#667 & solana-program/associated-token-account#154 & aligns with the effort to standardize CI workflows across solana-program repos. Migrates from pnpm-based script setup to Makefile.
Details
.mtsscriptsFollow up work
This effort was meant to translate the existing flows to the new ones. However, it seems like there are a number of checks missing that should be added next: