[confidential-transfer] Deprecate try_combine_lo_hi_u64 function#712
Merged
samkim-crypto merged 1 commit intosolana-program:mainfrom Sep 15, 2025
Merged
Conversation
joncinque
approved these changes
Sep 15, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The function
try_combine_lo_hi_u64contains logic error. The intended behavior is to shiftamount_hiwith the bit-length and add it withamount_lo.The function is actually not used anywhere in the crate and I think we just missed removing this function during refactoring. This is why this function did not affect the tests.
Summary of Changes
I considered fixing this function, but since it is not used anywhere in the crate, I thought it would actually be best to just remove it. The current crate version is v0.5.0, so I deprecated the function for v0.6.0.