[program] Reorder confidential transfer fee harvest logic to terminate early when possible#749
Merged
samkim-crypto merged 2 commits intosolana-program:mainfrom Sep 30, 2025
Conversation
joncinque
previously approved these changes
Sep 30, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just a nit, looks good otherwise!
| // Checks that the withdraw authority ElGamal public key associated with the | ||
| // mint is consistent with what was actually used to generate the zkp. | ||
| let confidential_transfer_fee_config = | ||
| mint.get_extension_mut::<ConfidentialTransferFeeConfig>()?; |
Contributor
There was a problem hiding this comment.
nit: can probably just use mint.get_extension since no changing is required
Contributor
Author
There was a problem hiding this comment.
Yeah good point. I guess we never really needed to borrow the mint as mut.
joncinque
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, in the confidential transfer logic, the summation of fee ciphertexts happens before some of the basic account checks. If some of the basic account checks fail, then the expensive summation of ciphertexts is rendered unnecessary.
Summary of Changes
I reordered the logic so that some of basic account checks happen before the summation of the ciphertexts.