[confidential-transfer-fee] Add check_program_account in confidential transfer fee for early termination and better error message#764
Merged
samkim-crypto merged 2 commits intosolana-program:mainfrom Oct 6, 2025
Conversation
…rmination and better error message
buffalojoec
previously approved these changes
Oct 6, 2025
| &account_infos[..num_signers], | ||
| )?; | ||
|
|
||
| check_program_account(destination_account_info.owner)?; |
Contributor
There was a problem hiding this comment.
If you want, you could also add this up on line 115 under process_withdraw_withheld_tokens_from_mint, for consistency.
Contributor
Author
There was a problem hiding this comment.
Oh good point! Just added.
buffalojoec
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the following audit report:
L-02: Missing check_program_account before unpack/mutate (pattern across multiple call sites)
Location(s):
program/src/extension/confidential_transfer_fee/processor.rs:#L182-L221 (destination account)
program/src/extension/confidential_transfer_fee/processor.rs:#L326-L341 (mint in harvest-to-mint)
Impact (why this matters): Fails late with less clear errors when non–Token-2022 accounts are supplied; adds compute and reduces observability. No privilege escalation or funds loss; failure is confined to the current transaction.
Description (root cause): Unpack/mutate without first calling check_program_account(..).
Remediation: Insert check_program_account(owner)? before unpack/mutation.