[program] Add cpi guard logic in confidential extensions#819
Merged
joncinque merged 1 commit intosolana-program:mainfrom Nov 3, 2025
Merged
Conversation
samkim-crypto
force-pushed
the
confidential-transfer-cpi
branch
from
2cf53ae to
ef44ec7
Compare
Contributor
Author
|
@joncinque I think the CI seems to pass, but there seems to be some hanging in the workflow. This should be a pretty simple PR, so it would be nice if you can double check 🙏 |
joncinque
approved these changes
Nov 3, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! We've been having issues with that cache for a while, I wonder if we should start disabling debug info on our test builds to reduce disk space usage... let me investigate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The confidential transfer logic does not check for CPI guard. Although there is actually no way for another program to generate a ZKP to instigate a valid confidential transfer, it would be more complete to check and consistent to check for an active CPI guard in the confidential transfer logic as well.
Summary of Changes
Added CPI guard check on confidential transfers and confidential mints.