[js-client] Add tsc --noEmit to the js client test script and fix type error#885
Merged
samkim-crypto merged 2 commits intosolana-program:mainfrom Dec 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If we current run
pnpm tsc --noEmiton the js client, we get the following error:My understanding is that the
sendAndConfirmTransactionFactorystrictly requires aTransactionBlockhashLifetime. However,assertIsSendableTransactiontypes the variable as aFullySignedTransactionunion, causing a type mismatch since the factory cannot handle nonce-based expiration.Summary of Changes
I added
assertIsTransactionWithBlockhashLifetimeintest/_setup.tsto explicitly narrow the transaction type to one using a blockhash.I updated the
testscript inpackage.jsonto runtsc --noEmitbeforeavato ensure test files are type-checked during builds/tests.