add clap requires to flags that depent on --report#111
Merged
solidiquis merged 1 commit intosolidiquis:masterfrom Apr 2, 2023
Merged
add clap requires to flags that depent on --report#111solidiquis merged 1 commit intosolidiquis:masterfrom
solidiquis merged 1 commit intosolidiquis:masterfrom
Conversation
solidiquis
approved these changes
Apr 2, 2023
Owner
solidiquis
left a comment
solidiquis
left a comment
There was a problem hiding this comment.
Ahhh I had no idea about the requires API thanks for this!
This was referenced Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While playing around with
etI was wondering why--humanhad no effect until I noticed that it's supposed to be used in combination with--report.This adds the
requirestag to--humanand--file-namein order to print a useful error message when these options are used without--report.A better alternative approach would be to implement something like:
et --report=human,file-name, but I think that's only possible with clap's Builder API.