Add option to print size on the left#61
Conversation
|
Ooh, just realized I forgot to add a test for combining left align and non-default precision. Should be implemented, just don't have a test for it. Will add tonight |
Additionally, fix the implementation for that case
solidiquis
left a comment
There was a problem hiding this comment.
Thanks for whipping this up. I won't be able to take a deeper look until later in the week as it's a work week, but I left some questions.
It also bothers me a bit that the root directory's disk usage isn't aligned with everyone else's. Would it be too difficult to offset that as well? Or perhaps there are other considerations that I'm missing.
Not sure what you mean by this, everything is aligned in the output for me. Maybe you were talking about the string literals in the |
|
Ahh yes that was what I was referring to. In that case fantastic. I'll do a deeper review tonight! Also I did not mean to edit your comment above. I did not know that was even possible. |
solidiquis
left a comment
There was a problem hiding this comment.
Everything looks great! Could you just go through and add doc comments to all the places I noted? I know that it's pretty obvious what a lot of these things are doing but it's still something I wish to enforce to be thorough.
|
Looks good to me! Thanks again for the contribution @bryceberger. For future reference if you wouldn't mind an update to the usage section of the README whenever new cli argument/options are introduced that'd be awesome. But I got it this time around :] |
|
And wow this looks so nice :D |
|
I included a screenshot in the README and decided to add |
Added option to left-align disk usage