Conversation
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
|
Visit the preview URL for this PR (updated for commit a3477a8): https://gloo-edge--pr11075-bump-k8s-tv8xf7sq.web.app (expires Wed, 24 Dec 2025 19:59:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
d8d9ca4 to
d23a04b
Compare
Signed-off-by: omar <omar.hammami@solo.io>
d23a04b to
493d9c5
Compare
Signed-off-by: omar <omar.hammami@solo.io>
GetObjectKind can return nil Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
controller-runtime drops the kind from the object but we know it will always be routeOptionGK in this func Signed-off-by: omar <omar.hammami@solo.io>
| return "" | ||
| } | ||
|
|
||
| if gvk := r.Object.GetObjectKind().GroupVersionKind(); gvk.Kind != "" { |
There was a problem hiding this comment.
after bumping controller-runtime this was returning nothing
r.Object.GetObjectKind().GroupVersionKind()
There was a problem hiding this comment.
Pull request overview
This PR updates Kubernetes-related dependencies from v0.33.x to v0.34.2, along with upgrading Gateway API from v1.3.0 to v1.4.0 and migrating from github.com/golang/mock to go.uber.org/mock. The changes include regenerated mock files, updated test imports, CRD modifications, and a breaking API change where GatewayTLSConfig was renamed to ListenerTLSConfig in the Gateway API.
Key Changes
- Upgraded Kubernetes dependencies to v0.34.2 and Gateway API to v1.4.0
- Migrated mock generation from golang/mock to go.uber.org/mock
- Updated Gateway API type reference from
GatewayTLSConfigtoListenerTLSConfig
Reviewed changes
Copilot reviewed 219 out of 221 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go to 1.25.5, k8s to v0.34.2, gateway-api to v1.4.0, and numerous other dependency version bumps |
| test/mocks/**/*.go | Regenerated mock files with go.uber.org/mock, updated to use descriptive parameter names and any type |
| projects/gloo/pkg/validation/server_test.go | Updated mock import from golang/mock to go.uber.org/mock |
| projects/gloo/cli/pkg/cmd/gatewayapi/convert/convert.go | Changed return type from GatewayTLSConfig to ListenerTLSConfig |
| projects/gateway2/translator/sslutils/*.go | Updated function signatures and tests to use ListenerTLSConfig |
| projects/gateway2/translator/listener/*.go | Updated TLS configuration type references to ListenerTLSConfig |
| projects/gateway2/translator/plugins/routeoptions/query/query.go | Fixed to use constant instead of runtime GVK lookup |
| projects/gateway2/translator/plugins/listeneroptions/listener_options_plugin_test.go | Removed ResourceKind field assignment |
| projects/gateway2/query/*.go | Added GVK resolution logic and updated go:generate directive |
| projects/gateway2/proxy_syncer/proxy_syncer.go | Updated Istio GVR constant reference |
| projects/gateway2/crds/tcproute-crd.yaml | Updated Gateway API CRD to v1.4.0 with new fields |
| install/helm/gloo/crds/*.yaml | Removed creationTimestamp fields and updated controller-gen version |
| test/kubernetes/e2e/features/metrics/edge.go | Updated to use NewTextParser with LegacyValidation parameter |
| docs/content/**/*.md | Updated documentation with new dependency versions and anchor link corrections |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io> Co-authored-by: David Jumani <dj.davidjumani1994@gmail.com>
Signed-off-by: Michael Bridgen <mikeb@squaremobius.net> Co-authored-by: Tim Flannagan <timflannagan@gmail.com>
Description
Bump k8s deps to 1.34. This also forced bumping Gateway API to 1.4.0 due to conflicts.
Bump go to 1.25.5.
Notable changes:
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: