Skip to content

Bump k8s#11075

Merged
puertomontt merged 39 commits intomainfrom
bump-k8s
Dec 17, 2025
Merged

Bump k8s#11075
puertomontt merged 39 commits intomainfrom
bump-k8s

Conversation

@puertomontt
Copy link

@puertomontt puertomontt commented Dec 15, 2025

Description

Bump k8s deps to 1.34. This also forced bumping Gateway API to 1.4.0 due to conflicts.
Bump go to 1.25.5.

Notable changes:

  • pin docker api version to 1.41 to fix cloud-build failures
  • golangci-lint: had to update version (use v2) and update the config acordingly
  • gwv1.GatewayTLSConfig was replaced with gwv1.ListenerTLSConfig (internal change, doesn't effect users)
  • controller-runtime fake client drops obj kind ⚠️ Fakeclient: Clear typemeta for structured  kubernetes-sigs/controller-runtime#3229. See changes in projects/gateway2/translator/plugins/routeoptions/query/query.go and projects/gateway2/query/httproute.go

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

davidjumani and others added 3 commits December 15, 2025 15:15
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Visit the preview URL for this PR (updated for commit a3477a8):

https://gloo-edge--pr11075-bump-k8s-tv8xf7sq.web.app

(expires Wed, 24 Dec 2025 19:59:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
@puertomontt puertomontt requested a review from a team as a code owner December 16, 2025 00:52
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
seems like controller-runtime doesn't populate TypeMeta when listing for fake client

Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
GetObjectKind can return nil

Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
controller-runtime drops the kind from the object
but we know it will always be routeOptionGK in this func

Signed-off-by: omar <omar.hammami@solo.io>
return ""
}

if gvk := r.Object.GetObjectKind().GroupVersionKind(); gvk.Kind != "" {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after bumping controller-runtime this was returning nothing
r.Object.GetObjectKind().GroupVersionKind()

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Kubernetes-related dependencies from v0.33.x to v0.34.2, along with upgrading Gateway API from v1.3.0 to v1.4.0 and migrating from github.com/golang/mock to go.uber.org/mock. The changes include regenerated mock files, updated test imports, CRD modifications, and a breaking API change where GatewayTLSConfig was renamed to ListenerTLSConfig in the Gateway API.

Key Changes

  • Upgraded Kubernetes dependencies to v0.34.2 and Gateway API to v1.4.0
  • Migrated mock generation from golang/mock to go.uber.org/mock
  • Updated Gateway API type reference from GatewayTLSConfig to ListenerTLSConfig

Reviewed changes

Copilot reviewed 219 out of 221 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updated Go to 1.25.5, k8s to v0.34.2, gateway-api to v1.4.0, and numerous other dependency version bumps
test/mocks/**/*.go Regenerated mock files with go.uber.org/mock, updated to use descriptive parameter names and any type
projects/gloo/pkg/validation/server_test.go Updated mock import from golang/mock to go.uber.org/mock
projects/gloo/cli/pkg/cmd/gatewayapi/convert/convert.go Changed return type from GatewayTLSConfig to ListenerTLSConfig
projects/gateway2/translator/sslutils/*.go Updated function signatures and tests to use ListenerTLSConfig
projects/gateway2/translator/listener/*.go Updated TLS configuration type references to ListenerTLSConfig
projects/gateway2/translator/plugins/routeoptions/query/query.go Fixed to use constant instead of runtime GVK lookup
projects/gateway2/translator/plugins/listeneroptions/listener_options_plugin_test.go Removed ResourceKind field assignment
projects/gateway2/query/*.go Added GVK resolution logic and updated go:generate directive
projects/gateway2/proxy_syncer/proxy_syncer.go Updated Istio GVR constant reference
projects/gateway2/crds/tcproute-crd.yaml Updated Gateway API CRD to v1.4.0 with new fields
install/helm/gloo/crds/*.yaml Removed creationTimestamp fields and updated controller-gen version
test/kubernetes/e2e/features/metrics/edge.go Updated to use NewTextParser with LegacyValidation parameter
docs/content/**/*.md Updated documentation with new dependency versions and anchor link corrections

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
Signed-off-by: omar <omar.hammami@solo.io>
@puertomontt puertomontt enabled auto-merge (squash) December 17, 2025 20:15
@puertomontt puertomontt merged commit 6d518df into main Dec 17, 2025
20 checks passed
@puertomontt puertomontt deleted the bump-k8s branch December 17, 2025 20:22
JCigan pushed a commit that referenced this pull request Dec 19, 2025
Signed-off-by: omar <omar.hammami@solo.io>
Co-authored-by: David Jumani <dj.davidjumani1994@gmail.com>
This was referenced Dec 24, 2025
Rachael-Graham pushed a commit that referenced this pull request Mar 3, 2026
Signed-off-by: Michael Bridgen <mikeb@squaremobius.net>
Co-authored-by: Tim Flannagan <timflannagan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants