Skip to content

[TAM]: Fix TAM notification and vslib implementation#1606

Merged
kcudnik merged 9 commits into
sonic-net:masterfrom
Pterosaur:fix_tam
Jun 12, 2025
Merged

[TAM]: Fix TAM notification and vslib implementation#1606
kcudnik merged 9 commits into
sonic-net:masterfrom
Pterosaur:fix_tam

Conversation

@Pterosaur
Copy link
Copy Markdown
Contributor

@Pterosaur Pterosaur commented May 28, 2025

  1. Fix TAM notification issue that uses the wrong RID instead of VID
  2. Add default attributes for TAM objects

Signed-off-by: Ze Gan <ganze718@gmail.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ze Gan <ganze718@gmail.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ze Gan <ganze718@gmail.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur requested a review from kcudnik May 29, 2025 04:23
@Pterosaur
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur requested review from jimmyzhai and r12f May 30, 2025 05:15
Comment thread syncd/NotificationProcessor.cpp Outdated
Signed-off-by: Ze Gan <ganze718@gmail.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@Pterosaur Pterosaur requested a review from kcudnik May 31, 2025 10:25
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread syncd/NotificationProcessor.cpp Outdated
Comment thread vslib/SwitchStateBase.cpp Outdated
attr.value.objlist.list = nullptr;

return set(SAI_OBJECT_TYPE_SWITCH, m_switch_id, &attr);
return SAI_STATUS_SUCCESS;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second return is not needed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread vslib/SwitchStateBase.cpp Outdated
Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur Pterosaur requested a review from kcudnik June 3, 2025 12:39
@Pterosaur
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@Gfrom2016 Gfrom2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcudnik kcudnik merged commit d7c1de8 into sonic-net:master Jun 12, 2025
15 checks passed
@Pterosaur Pterosaur deleted the fix_tam branch June 12, 2025 14:24
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #1615

stephenxs pushed a commit to stephenxs/sonic-sairedis that referenced this pull request Aug 30, 2025
…sonic-net#62)

Fix TAM notification issue that uses the wrong RID instead of VID
Add default attributes for TAM objects

Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants