Begin deprecating old ObjXX labels#79
Open
AlexField442 wants to merge 26 commits intosonicretro:masterfrom
Open
Begin deprecating old ObjXX labels#79AlexField442 wants to merge 26 commits intosonicretro:masterfrom
AlexField442 wants to merge 26 commits intosonicretro:masterfrom
Conversation
Per this discussion (sonicretro#78), objects will be moved over to a more descriptive naming scheme. Subroutines they use will also be named after them.
f_bigring should be renamed in the future, as it appears to be used upon entering a Special Stage...
Unsure if these are actually bugs, though the lines themselves appear to be redundant as the line above already forces them into their waiting animation.
Member
|
Let me know when this is done and ready for merging! |
Contributor
Author
|
I need some help, for some reason it is throwing errors relating to 'out of range of index' for random objects after I relabled Obj0E. |
Member
|
There were some undefined-symbol errors, which led to bogus out-of-range errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will take a long while to fully complete, so may begin it now.
MAKE SURE TO KEEP HISTORICAL LABELS, as a lot of guides rely on them for navigation. I have also gone through the effort of restoring some historical address-based labels (taken from the Nemesis disassembly) that were not present previously, as well as renaming mappingASM files (make sure that Flex2 and SonLVL project files are updated as well).
So far, the following objects have been updated: